Ctrl-C causes unexpected behavior in riak-admin top and more [JIRA: TOOLS-247]

[angrycub]

The change from sudo to su is causing an issue when Ctrl-C is being pressed in interactive applications such riak attach, riak-admin top.

When Ctrl-C is pressed you receive

                   Session terminated, killing shell... ...killed.

in the case of riak-admin top, the output continues in the background

This behavior appears to be caused by a change in the check_user() function from

    exec sudo -H -u $RUNNER_USER -i $RUNNER_SCRIPT_DIR/$RUNNER_SCRIPT $@

https://github.com/basho/node_package/blob/1.3.8/priv/base/env.sh#L169

to

    exec su - $RUNNER_USER -c "$RUNNER_SCRIPT_DIR/$RUNNER_SCRIPT $ESCAPED_ARGS"

https://github.com/basho/node_package/blob/develop/priv/base/env.sh#L239.

I was able to resolve it by changing -c to --session-command on CentOS, but I doubt the portability of that. I also was able to fiddle the scripts around in such a way that the interactive commands used a separate version of check_user that used sudo and allowed stop and start to use su.

[kesslerm]

This is partially addressed by #198. At least the user is no longer prompted to press Ctrl+C.
However, Ctrl+C is a standard *nix way of terminating an application, so the underlying issue should still be addressed.

[kesslerm]

https://www.novell.com/support/kb/doc.php?id=7009640 suggests that the change in behaviour su -c (for the coreutils version of su) was made to address a possible security issue that allowed a tty to be hijacked. su --session-command may re-introduce this issue.

Also Debian derived distributions use a different su implementation that does not support --session-command.