Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamal setup fails if kamal-proxy is not up to date #1298

Open
gregschmit opened this issue Dec 13, 2024 · 2 comments
Open

kamal setup fails if kamal-proxy is not up to date #1298

gregschmit opened this issue Dec 13, 2024 · 2 comments

Comments

@gregschmit
Copy link

I recently upgraded an application to kamal 2.4.0 and got this when running kamal setup:

Releasing the deploy lock...
  Finished all in 69.8 seconds
  ERROR (RuntimeError): Exception while executing on host app0.schmit.net: kamal-proxy version v0.8.1 is too old, run `kamal proxy reboot` in order to update to at least v0.8.4
Error: Process completed with exit code 1.

I use kamal setup so if I add nodes then the CI job will provision them if they require it and then it will call deploy anyway. I wish there was an option to have kamal itself run kamal proxy reboot if the proxy was upgraded and needs to be rebooted, and then perhaps kamal could continue with re-running deploy. I was considering trying something like my CI job doing kamal setup || kamal proxy reboot || kamal deploy but that seems hacky as setup could fail for a number of different reasons in which case I don't want to run proxy reboot and deploy.

Would such a feature (where kamal detects that the proxy needs to be rebooted and there is a CLI option to auto-reboot the proxy if needed) be accepted by the maintainers of this project were I to submit a PR?

@gregschmit
Copy link
Author

FYI, it's a public project so if you want to see the full logs: https://github.com/gregschmit/rails-rest-framework/actions/runs/12318981923/job/34384995326. You can see I was also struggling with the bug in 2.3.0 with kamal claiming GITHUB_TOKEN was not in the secrets file but 2.4.0 seems to have fixed that.

@gregschmit
Copy link
Author

The CLI flag could perhaps be called --auto-proxy-reboot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant