-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use stable Viem / Wagmi versions #63
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
package.json
Outdated
"viem": "beta", | ||
"wagmi": "beta" | ||
"viem": "^2.7.9", | ||
"wagmi": "^2.5.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think these be 2.x
? that's what we have in op-viem and how wagmi has their peer dependencies set up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change it to that, my understanding of the ^
operator is that ^2.7.9
and ^2.x
have the same effect as they both allow any minor and patch version within 2
@zencephalon looking good! can we update the example app to use this version? do you think we can get the config changes in this update too? specifically, users shouldnt have to configure op chains as specified here anymore because viem 2 chains have op stack addresses. documentation should be updated to reflect this as well. |
i think we should also just use the viem 2 actions now instead of op-viem |
@lukasrosario The Viem 2 actions don't map cleanly to op-viem or I would have done it already :/ E.g. Viem doesn't provide any simulation actions |
The example app automatically uses whatever version is in the Workspace, no? |
ah i see ok, ack on the viem 2 actions. and yeah you're right it does use workspace, should be good.
|
nice, can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀 awesome. can follow up but looks like something happened w/ the test coverage and now it's reporting on the example app
No description provided.