-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow accents in file names #17
base: master
Are you sure you want to change the base?
Conversation
Thanks for working on this! There are a few points which I think stop me from merging this quite yet. My understanding of this feature is that we need to:
I am confused as to why you seem to have |
this will encode name to utf8 before sending closes: basak#16
which is more flexible and allow user to decide which codec will be used to encode characters with ord() > 125
rebased to current master |
Addressing your comments (after long pause):
which will convert name to unicode and boto itself will then correctly handle upload of unicode names (u'foo')
|
@basak Was there still something blocking merge of this? |
I rebased the patch to master and add there some python3 compatibility code. |
Closes: #16