Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rollouts resource #274

Open
2 tasks done
ykizin opened this issue Sep 12, 2024 · 1 comment
Open
2 tasks done

Add support for Rollouts resource #274

ykizin opened this issue Sep 12, 2024 · 1 comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ykizin
Copy link

ykizin commented Sep 12, 2024

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

Hello! Please add support for the Rollouts resource, which replaces Deployment when using the Argo Rollouts utility. In general, this resource has the same structure as Deployment (except for some additional fields)

Proposed Solution

Add support for Rollouts resource

Alternatives Considered

No response

Additional Information

No response
@ykizin ykizin added the kind/enhancement Categorizes issue or PR as related to an improvement. label Sep 12, 2024
@csatib02
Copy link
Member

csatib02 commented Sep 14, 2024 •
edited
Loading

Hey @ykizin,
This sounds like a great and easy-to-add enhancement. I'm unsure if we will have time for this in the future, but contributions are always welcome!

AFAIK, there should be nothing that needs to be changed on the webhook's side for this to work, but this should be atleast manually tested e2e.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Nov 17, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Nov 17, 2024
@csatib02 csatib02 added triage/accepted Indicates an issue or PR is ready to be actively worked on. lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Nov 17, 2024
@csatib02 csatib02 moved this from 🆕 New to 🔖 Ready for work in Project backlog Nov 17, 2024
@csatib02 csatib02 moved this from 🔖 Ready for work to 📋 Backlog in Project backlog Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Project backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ykizin @csatib02