Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make e2e a separate module #131

Open
ramizpolic opened this issue Feb 12, 2024 · 2 comments
Open

Make e2e a separate module #131

ramizpolic opened this issue Feb 12, 2024 · 2 comments
Labels
area/test lifecycle/keep Denotes an issue or PR that should be preserved from going stale.

Comments

@ramizpolic
Copy link
Member

The e2e is part of the main module which creates unnecessary dependencies. Make e2e a separate module to remove this. Update Makefile (and other scripts) that interact with e2e.
@ramizpolic ramizpolic mentioned this issue Feb 12, 2024
Merged
@ramizpolic ramizpolic moved this from 🆕 New to Next up in Project backlog Feb 13, 2024
@ramizpolic
Copy link
Member Author

Do we need to import operator @akijakya? Is there something specific on why that is the case?

@akijakya
Copy link
Member

Do we need to import operator @akijakya? Is there something specific on why that is the case?

It is used by the e2e tests to create a patch for the Vault cr so the startup secrets are updated, triggering a reload event. There might be other ways to do it though...

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Apr 14, 2024
@csatib02 csatib02 removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Apr 14, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jun 16, 2024
@csatib02 csatib02 added lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jun 16, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 16, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Projects
Project backlog
Status: Next up
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramizpolic @akijakya @csatib02