Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to set the webhook's annotations default values #157

Open
2 tasks done
virtyaluk opened this issue Aug 18, 2024 · 1 comment
Open
2 tasks done

An option to set the webhook's annotations default values #157

virtyaluk opened this issue Aug 18, 2024 · 1 comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.

Comments

@virtyaluk
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

Hello there!

I recently encountered a problem where a 3rd party service attempted to reference a Kubernetes secret value defined in the webhook format (e.g. vault:secret/...) and failed to do so due to an internal Secrets Webhook error while performing Kubernetes auth. Surely, the error related to a 3rd party service was missing Secrets Webhook annotations due to its limited configuration options, and therefore default vault settings were used, namely vault-skip-verify: false and vault-add: https://vault:8200. There's no way for me to work around this issue since my vault cluster is installed into a dedicated vault namespace and I'm not using TLS.

Proposed Solution

I'd like to see the webhook expose additional configuration options (Helm values) to set defaults for the values used in place of absent annotations. Namely, I'd like to set the default values of VAULT_ADDR and VAULT_SKIP_VERIFY envs at the webhook installation time and use it thereupon.

Thanks.

Alternatives Considered

No response

Additional Information

No response

@virtyaluk virtyaluk added the kind/enhancement Categorizes issue or PR as related to an improvement. label Aug 18, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Oct 20, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Oct 20, 2024
@csatib02 csatib02 removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Oct 20, 2024
@csatib02
Copy link
Member

Hey @virtyaluk,

Seems like a reasonable addition to the project, it would be awesome if you could work on adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.
Projects
None yet
Development

No branches or pull requests

2 participants