Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the length limit on strings #5

Open
julochrobak opened this issue Jul 5, 2012 · 2 comments
Open

removing the length limit on strings #5

julochrobak opened this issue Jul 5, 2012 · 2 comments

Comments

@julochrobak
Copy link
Member

There is a maximum length, MAX_STRING (defined in config.h file, currently at value of 1024), restriction on all string values. The string data type should not put any constraints on the length of the values.

This task is to completely remove the MAX_STRING restriction from the string data type. In order to do that, the chunked encoding of HTTP response from bandicoot could cut a tuple in the middle of a string attribute.

@ostap
Copy link
Member

ostap commented Aug 28, 2012

here are my review comments:

  1. looks like splitting the data on MAX_BLOCK boundaries introduces a lot of clutter. can we avoid it? the values are anyways loaded into the memory.
  2. trailing white spaces

@julochrobak
Copy link
Member Author

  1. the MAX_BLOCK is unfortunately coming as a requirement from other piece of the code 'sys_proxy'. The data sent by the processor to the main process must be at most of the MAX_BLOCK size. I did not manage to come up with a simpler solution without rewriting the sys_proxy part.
  2. I removed the trailing spaces.
  3. I added one more FIXME into the bandicoot.c, there seems to be a memory leak on the tuples of the return if a client closes the connection before all the tuples were sent to the client. This now is applicable to the 'PBuf' instance as well.
  4. There is one more use case of the MAX_STRING which I did not get rid of. The string literals in the language must be at most MAX_STRING characters long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants