Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modal components support #56

Closed
pierpo opened this issue Feb 5, 2024 · 1 comment
Closed

Add Modal components support #56

pierpo opened this issue Feb 5, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation feature request

Comments

@pierpo
Copy link
Member

pierpo commented Feb 5, 2024

Is your feature request related to a problem? Please describe.

Right now we have no clear way to have little modals on top of our screens.
There are ways to do it, but we have no clear recommendation yet 😊

This might need some additions in the core (even though I think what we have might be enough already).

Describe the solution you'd like

<SpatialNavigationRoot>
  <Button /> {/* should not be active anymore */}
  <Modal isOpen>
    <Button /> {/* should be active */}
  </Modal>
</SpatialNavigationRoot>

Describe alternatives you've considered
...

Additional context
N/A

@pierpo pierpo added feature request documentation Improvements or additions to documentation labels Feb 5, 2024
@pierpo
Copy link
Member Author

pierpo commented Feb 13, 2024

This was merged. Nothing in the core of the lib, but an example is now provided 😊

#59

@pierpo pierpo closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request
Projects
None yet
Development

No branches or pull requests

1 participant