From fc9150f86596ea667d09b4611933b118b171c366 Mon Sep 17 00:00:00 2001 From: Matthieu Gicquel Date: Tue, 9 Jan 2024 15:23:06 +0100 Subject: [PATCH] fix(eslint-plugin): config was broken because of missing char in rule name (#111) * fix missing @ in rule name * revert createRelease: "github" it request a GH_TOKEN, which is painful if the `version` step is not done in CI --- lerna.json | 3 +-- packages/eslint-plugin/lib/configs/recommended.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lerna.json b/lerna.json index c5cea39..4f2a43f 100644 --- a/lerna.json +++ b/lerna.json @@ -7,8 +7,7 @@ "private": false, "message": "chore(release): Publish", "conventionalCommits": true, - "allowBranch": "main", - "createRelease": "github" + "allowBranch": "main" } } } diff --git a/packages/eslint-plugin/lib/configs/recommended.ts b/packages/eslint-plugin/lib/configs/recommended.ts index 955e5a0..d9ad33c 100644 --- a/packages/eslint-plugin/lib/configs/recommended.ts +++ b/packages/eslint-plugin/lib/configs/recommended.ts @@ -35,7 +35,7 @@ export const recommendedConfig = defineConfig({ "@typescript-eslint/indent": "off", "@typescript-eslint/no-explicit-any": "error", "@typescript-eslint/no-non-null-assertion": "error", - "typescript-eslint/no-shadow": "error", + "@typescript-eslint/no-shadow": "error", "no-console": ["error", { allow: ["warn", "error"] }], "no-return-await": "error", "array-callback-return": "error",