Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXR: support Tiled files, better detection of channel names, update TinyExr #3469

Merged
merged 3 commits into from
Oct 31, 2024
Merged

EXR: support Tiled files, better detection of channel names, update TinyExr #3469

merged 3 commits into from
Oct 31, 2024

Conversation

aras-p
Copy link
Contributor

@aras-p aras-p commented Oct 30, 2024

Improve EXR file support. Due to fast load times, I use RenderDoc as a EXR viewer :)

  • Update tinyexr 3rd party library to the latest version
  • Support "tiled" EXR files. Those are common from movie assets, e.g. Animal Logic ALab is basically only those. There are some simple ones in OpenEXR test suite too.
  • Improve detection of RGBA channel names. The convention seems to be that either the channels are just named like that (which RenderDoc was already handling), or they are named like ".", with "layer name" being whatever the production workflow decides. Again, the ALab files above have channels like rgb.R, rgb.G etc. TinyExr viewer application and Blender both seem to interpret channel names in that way too.

@aras-p aras-p force-pushed the update_tinyexr branch 2 times, most recently from 80e2fc5 to 927ce68 Compare October 30, 2024 14:35
baldurk
baldurk requested changes Oct 31, 2024
View reviewed changes
Copy link
Owner

@baldurk baldurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! I've noted a couple of minor things to tweak but then this should be ready.

renderdoc/3rdparty/tinyexr/tinyexr.h Outdated Show resolved Hide resolved
renderdoc/core/image_viewer.cpp Show resolved Hide resolved
renderdoc/3rdparty/tinyexr/README.md Show resolved Hide resolved
aras-p added 3 commits October 31, 2024 13:37
@aras-p
Update tinyexr to current (1.0.9, from 2024 Jul)
5cb6fd0 
Disable some warnings that happen on vs2015/2019
while building it, since whole build uses
warnings as errors.
@aras-p
EXR: support tiled images
42a73bb
@aras-p
EXR: more standard RGBA channel name detection
ef39e52 
Various EXR images especially from movie assets do not simply have "R"
etc as channel names; the convention seems to be to have "layer name",
".", "color channel name". For example, channels in EXR might be
"rgb.R", "rgb.G", "rgb.B", which RenderDoc was not detecting previously
and displaying an all-black image.
@aras-p aras-p requested a review from baldurk October 31, 2024 11:48
@baldurk baldurk merged commit 0baf7b5 into baldurk:v1.x Oct 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baldurk baldurk baldurk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aras-p @baldurk