Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forex support #1085

Open
steveklabnik opened this issue Mar 25, 2014 · 8 comments · May be fixed by #1237
Open

Forex support #1085

steveklabnik opened this issue Mar 25, 2014 · 8 comments · May be fixed by #1237
Labels
In development

Comments

@steveklabnik
Copy link
Contributor

The dashboard already shows the full details of the responses, so there doesn't need to be any specific changes. However, we can do better than that: it'd probably be good to expose which charges were in a different currency, and allow you to search/sort by currency type.

These changes will be largely cosmetic, because 1.1 already has the currency field.
@steveklabnik steveklabnik mentioned this issue Mar 25, 2014
Open
@dmdj03
Copy link

dmdj03 commented Apr 23, 2014

Here are the changes in the dashboard for forex:

Activity view:

  • Show original currency amount in the transactions table and USD converted amount

Debit details page:

  • Show original currency amount in the debit details page and USD converted amount

Debit modal:

  • Debit modal: When charging a card, the user can select the currency type

Refund modal:

  • Refunds: The refund modal will display the original amount in the original currency. You can only refund in the original currency.
  • We’ll also show a USD converted amount for the MP’s reference.

Search:

  • search for amount across all currencies (e.g. 10.00 returns USD and EUR if both exists)

@dmdj03
Copy link

dmdj03 commented Apr 23, 2014

screen shot 2014-04-23 at 4 19 47 pm
screen shot 2014-04-23 at 4 20 04 pm

@dmdj03
Copy link

dmdj03 commented Apr 24, 2014

screen shot 2014-04-23 at 6 51 42 pm
screen shot 2014-04-23 at 6 52 35 pm
screen shot 2014-04-23 at 6 51 57 pm

@kyungmin
Copy link
Contributor

@steveklabnik any thoughts?

@mjallday
Copy link
Contributor

search/sort by currency type.

this sounds not immediately useful to me. is there a use case for this?

agree that typing 100 into search should return 100 EUR txns and 100 USD txns however.

@kyungmin
Copy link
Contributor

"filter by" is probably more useful than "sort by" in this case.

@dmdj03
Copy link

dmdj03 commented Apr 25, 2014

I don't think either will be used frequently, especially sort by. Let's hold off on this until we get feedback from users.

@steveklabnik
Copy link
Contributor Author

I like it.

This was referenced May 10, 2014
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forex kyungmin/balanced-dashboard
4 participants
@steveklabnik @kyungmin @mjallday @dmdj03