Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #384 (caused by ps-tree) with modified local version #392

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BePo65
Copy link

@BePo65 BePo65 commented Nov 27, 2024

ps-tree throws an error, when used on newer windows systems (see issue #384 and indexzero/ps-tree#62).

As ps-tree is quite abandoned (last commit is more than a year old) and as ps-tree contains many vulnerabilities and deprecated packages, perhaps it makes sense to add a local copy of ps-tree with errors fixed.

That is what I did. I added a file containing a modified clone of ps-tree with errors fixed. This way in index.js only the import line had to be modified. Should ps-tree ever get updated, only this line has to be returned to its original state (with ps-tree reinstalled).

@MikeMcC399 MikeMcC399 mentioned this pull request Nov 28, 2024
@BePo65
Copy link
Author

BePo65 commented Nov 28, 2024

@bahmutov: is this pr an acceptable way to handle the situation that the package ps-tree seems to be unmaintained?

I created a pr for the problem in ps-tree (see indexzero/ps-tree#62) and created another pr (see indexzero/ps-tree#60) to find out, if this package is still alive. The last commit in indexzero/ps-tree is more than a year old and there are many unfixed vulnerabilities and deprecated dependencies.

My intention was to create a fast solution that easily can be replaced with an official solution (i.e. a fixed version of ps-tree), when that solution should be available.

@MikeMcC399
Copy link

@BePo65

I suggest to close this PR as there is not an urgent need for it and start-server-and-test does not directly use WMIC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants