Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using export_path with download.py caused errors in sync.py with sync_path #39

Open
SoxIn4 opened this issue Oct 21, 2023 · 1 comment
Open

using export_path with download.py caused errors in sync.py with sync_path #39

SoxIn4 opened this issue Oct 21, 2023 · 1 comment

Comments

@SoxIn4
Copy link

SoxIn4 commented Oct 21, 2023

Short version, I think add sync_path needs to be added to the front of the joins near lines 152, 207, 293, and 335. (the line numbers are from my fork and are a bit off, as I took the long road to get there and changed a bit more thinking it was necessary)

More info on what I saw here: https://macadmins.slack.com/archives/C04QVP86E/p1697777935371559?thread_ts=1697751693.656709&cid=C04QVP86E
More info about my conclusions here: https://macadmins.slack.com/archives/CDLQMGB6E/p1697873801412639

This was with the fork that was just merged.
@SoxIn4
Copy link
Author

SoxIn4 commented Oct 30, 2023

this is fixed in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SoxIn4