Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow should throw meaningful error on Node destruction #353

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Workflow should throw meaningful error on Node destruction #353

wants to merge 5 commits into from

Conversation

CherryPerry
Copy link
Collaborator

Throws proper.

Closes #350, see comments.

@CherryPerry CherryPerry requested a review from zsoltk January 28, 2022 12:56
@CherryPerry
Copy link
Collaborator Author

@zsoltk I have split executeWorkflow into executeWorkflow and maybeExecuteWorkflow. It is also possible to do executeWorkflow(strict: Boolean, action: () -> Unit) but in this case we need to change public API and client code to make it Maybe instead if Single (loosing backward compatibility and migration is required).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsoltk zsoltk Awaiting requested review from zsoltk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RxWorkflowNode causes CancellationException
1 participant
@CherryPerry