Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph.Pack: parse_dot_file numbers from 1, not from 0 #59

Open
eponier opened this issue Jun 13, 2017 · 1 comment
Open

Graph.Pack: parse_dot_file numbers from 1, not from 0 #59

eponier opened this issue Jun 13, 2017 · 1 comment

Comments

@eponier
Copy link

eponier commented Jun 13, 2017

Contrary to Rand which starts from 0. This implies that doing in sequence dot_output then parse_dot_file produces a graph with nodes numbered differently. The culprit is

ocamlgraph/src/pack.ml

Line 149 in 726e8d6

incr new_node;
.
@eponier eponier changed the title Graph.Pack: parse_dot_file numbers from 1, not from 0 Graph.Pack: parse_dot_file numbers from 1, not from 0 Jun 13, 2017
@backtracking
Copy link
Owner

You're right, that's inconsistent. It would be easy to fix (replacing "let new_node = ref 0" with 1 instead) but I'm a bit afraid it would break existing codes. Still hesitating...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@backtracking @eponier