-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting error on copying translated contentElements #500
Comments
Steps to reproduce:
Actual result:
Expected result:
|
To me it looks like this is not necessary related to the language. It looks like a duplication of #458. I guess this bug got introduced via #149 with a1cc4de.
|
A similar issue I also noticed, when I move a translated container element per drag and drop in page mode (connected mode) inside the same page. The translated element stays in the original position, the original element stays in de new position. Interestingly, only on the backend. It moves to the desired position on the frontend. |
behaviour of sorting is changed in two ways: * element at first position in container column * old: pid was used as target (leeds to broken sorting) * new: use -uid of container element for first column * new: use -uid of previous column child (if exists), (else -uid of container) * element after a container * old: -uid of container is used (leeds to broken sorting) * new: -uid of last child in containers last column is used we shift a migration command to fix broken sorting: dry-run: container:sorting run: container:sorting 0 must be called multiple for nested containers Fixes: #149
a1cc4de#diff-e83c9a53369a0fdfe0bbb24d68652192dcd70cfa7c252b211f2a01db9caef8abR67 We have a sorting issue when translating content. Removing this line, seems to fix the issue. |
Hello,
i got an error report by a colleague, mentioning the english translation of a german page is sorted on top or at the bottom of the page.
After investigation this issue i found that the problem comes from the b13/container extension, and exists on multiple TYPO3 instances.
This occures since the version 2.0.0 of this extension.
We found out it has to do with the class B13\Container\Hooks\Datahandler\CommandMapBeforeStartHook
Using the class from v1.6.1 sort the translated contentElements correctly. We are currently using v2.3.6, where the translated element is sorted wrong.
The resulting "cmdmap" looks right, so i don't see why this is the cause.
Another colleague claims the error is on line 141 and should be:
if ($this->tcaRegistry->isContainerElement($record['CType'])) { continue; }
It seems the following target points to the last element inside of the container, instead of the container itself, which is the element before the element that we pasted into the page. That inserted contentElement could be any contentElement or a container.
Thanks for the extension and for looking into it.
Kind Regards
Daniel Kruse
The text was updated successfully, but these errors were encountered: