Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon downloads on every route change #20

Open
dmbaranov opened this issue Sep 14, 2017 · 3 comments
Open

Icon downloads on every route change #20

dmbaranov opened this issue Sep 14, 2017 · 3 comments

Comments

@dmbaranov
Copy link

First of all, let me say thanks for this awesome work! You implemented a great idea of using CRA without ejecting it together with SSR, really like it! (If there would be a HMR I would like it even more! Because now I have to re-build client part every time I change it).

But one thing I noticed is that icon is downloading again and again each time you change the route. Not sure what causes this behaviour, but probably you do. It's not a big problem though, but would be cool to fix it somehow. Thanks!

screen shot 2017-09-15 at 01 33 13

@ayroblu
Copy link
Owner

ayroblu commented Sep 15, 2017

Without looking at the source code, I'm guessing the favicon doesn't exist so it's sending the raw HTML which isn't cached and no 404 right now

@dmbaranov
Copy link
Author

Well, actually this screenshot was taken from the freshly installed code of this repository :)

@ayroblu
Copy link
Owner

ayroblu commented Sep 15, 2017

Yeah that's what I'm saying, my code probably doesn't have it, feel free to put your own favicon in there and try again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants