Skip to content

Latest commit

 

History

History
69 lines (43 loc) · 4.85 KB

CONTRIBUTING.md

File metadata and controls

69 lines (43 loc) · 4.85 KB

Contributing to Fomantic-UI

📓 Support Questions

Questions regarding usage and support can be asked in GitHub Issues but if your question starts to become a conversation we will ask you to move it into our Discord. If you are looking for quick support Discord is the best place to ask.

After asking your question you may find that it is actually a bug or a feature which doesn't exist. At this point it's a good idea to submit a GitHub issue (if you haven't already) to request/report your issue. When you open an issue please use the issue templates and fill in as many of the sections as you can. This helps us triage issues without needing to ask lots of questions.

Bugs & Enhancements

🐛 Reporting Bugs

We use GitHub Issues to track all bugs and enhancements for FUI, before raising a bug please check to see if it has already been raised. If you find it has already been raised add a 👍 to the issue reactions to show you are also having the same issue. Please do not spam "+1", "bump" etc.

If you find that your issue has not already been raised please create a new issue and please follow the template provided.

When creating an issue you will be asked to create a JSFiddle to replicate your issue. You can fork this template which has the latest version of Fomantic ready to use.

🔮 Requesting Features

We also use GitHub Issues for new feature requests. Before submitting a new issue please check to see if it has already been requested. If you find that your issue has not already been requested feel free create a new issue and please follow the template provided. This helps us triage issues without needing to ask lots of questions.

When you create the issue please when possible include pictures or a JSFiddle, this can help contributors understand what your asking.

Naming Issues

When you create an issue please follow our naming convention this makes it easy to scan over issues.

Bugs: [Scope] x does not do y Enhancements: [Scope] x should do y

The scope is the component which has the issue or enhancement e.g. Segment, Grid, Dropdown etc. when you describe the issue in the summary keep it brief 60 characters max.

Tracking Issue Progress

As bugs and features are triaged they will be assigned to milestones. The best indication of when a change will land is to check the date on the upcoming milestones page.

📝 Pull Requests Guide

All pull requests should be merged into the develop branch. Make sure your branch is based from our develop branch and not the master.

Anyone can jump on the issues board and grab off bugs to fix. This is probably the best way to become a contributor to Fomantic. We only ask you to stick to these few rules to make it easier to merge/process your pull requests.

  • When you implement a new feature or fix a bug think about backwards compatibility. If your change is backwards compatible it is most likely to be merged sooner since you won't need to wait for a breaking change update.
  • Please commit using the AngularJS Git Commit Message Convention this is more of a nice to have and isn't required.
  • Please try and stick to a similar code style so everyone can read your code.
  • When you commit don't include your dist files, this can cause merge conflicts and also adds unnecessary changes to the PR.

Setup your enviroment

These few steps are the easiest way to setup your dev environment.

  1. Fork the main repository.
  2. Clone your fork and add the main repository as a remote
$ git clone https://github.com/<YOUR_GITHUB_USERNAME>/Fomantic-UI.git
$ cd Fomantic-UI
$ git remote add fui https://github.com/fomantic/Fomantic-UI.git
$ git fetch fui
  1. Checkout a new branch with the FUI develop branch as the base
$ git checkout -b <BRANCH_NAME> fui/develop

Now you can start working on your change. Once you submit your PR remember to merge into the develop branch NOT master.

The CONTRIBUTORS list

Once you contribute to the project you can be added the the contributors list for any categories you have contributed towards. If you think you should be on the list but aren't already you can request to be added via the all-contributors bot.