Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_settings.scss outdated #7

Open
ppowalowski opened this issue Feb 16, 2014 · 2 comments
Open

_settings.scss outdated #7

ppowalowski opened this issue Feb 16, 2014 · 2 comments

Comments

@ppowalowski
Copy link
Contributor

Seemingly the _settings.scss in stylesheet folder doesn't correspond to the _settings.scss in stylesheets.
Is there a way of automating the copying of the most present _settings.scss file after bower update?

Noticed because some variables like $h2-font-size were missing.

@axyz
Copy link
Owner

axyz commented Feb 17, 2014

Need to investigate if it is possible to trigger a script after bower update (but i don't think it is possible without using external scripts).

The cleanest solution in terms of maintainability should be to use an empty _settings.scss... by the way it could be useful to have commented settings to hack on.

being comments they do not affects the overall functionality of the application, so for now i think that it is reasonable to update the file manually (Hopefully they are not going to change it so often).

By the way I'm going to investigate possible clean solution (not involving the introduction of new actions to perform for the user when updating) which can keep _settings.scss in synch with the bower version.

Obviously I'm open to hear from you any suggestion about it.

Thanks for contributing

@ppowalowski
Copy link
Contributor Author

Yeah, I also thought about it and think in the first place it should be cautious not to overwrite changes the user potentially already made in his _settings.scss.
Also I don't know about any hook scripts in bower - it doesn't seem to be appealing due to sensitivity about user environment in which it would be run. We could provide a hint in the readme to make the users aware of the issue. Thus this isn't satisfying..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants