Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ztoc versioning needs clarification #494

Open
Kern-- opened this issue Mar 13, 2023 · 1 comment
Open

ztoc versioning needs clarification #494

Kern-- opened this issue Mar 13, 2023 · 1 comment

Comments

@Kern--
Copy link
Contributor

Kern-- commented Mar 13, 2023

Also, we have gzip_zinfo versions (

#define ZINFO_VERSION_ONE 1
#define ZINFO_VERSION_TWO 2
), and in the future maybe zstd_zinfo version(s).

How do we plan to track these versions altogether? a zinfo version change will possibly change zinfo bytes, which changes ztoc. (e.g. a 0.9 ztoc with version1 gzip_zinfo != a 0.9 ztoc with version2 gzip_zinfo, but to user they're the same 0.9 ztoc).

Originally posted by @djdongjin in #485 (comment)

@github-project-automation github-project-automation bot moved this to ❓ Ungroomed in soci-snapshotter Mar 15, 2023
@Kern-- Kern-- moved this from ❓ Ungroomed to 📋 Backlog in soci-snapshotter Mar 15, 2023
@Kern-- Kern-- self-assigned this Apr 14, 2023
@Kern--
Copy link
Contributor Author

Kern-- commented Oct 6, 2023

Another example of clarification needed: #853 (comment)

FileMetadata.XAttrs in the flatbuffer actually contains PAX records. Should/Could a major version change fix the naming?

@Kern-- Kern-- mentioned this issue Oct 6, 2023
@Kern-- Kern-- removed their assignment Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant