From f903bc80f2624cc7e2bc6fedc9705b5a52c895ad Mon Sep 17 00:00:00 2001 From: Emmanuel Arenas <35793527+emarenas@users.noreply.github.com> Date: Wed, 9 Nov 2022 04:45:17 -0600 Subject: [PATCH] Fixed S3 buckets ARN - Lakeformation integration (#75) * added bucket policies to enforce in transit encryption for s3 buckets * fixed cfn code style * Delete to avoid conflicts * Ingestion stage using sqoop * removed kite jar and added installation instructions * Enhanced EMR security configuration * Fixing Merge conflicts * Enhanced EMR security configuration * Alternative dataset dependency * Sqoop: Minor fixes and improvements * Added athena get workgroup permissions * deleted test transformation * Removed support for python 3.6 * Fixed LF bucket registration ARN When deploying the SDLF the s3 nested stack throws an error on all the *LakeFormationS3Registration resources. S3 bucket ARN changed form arn:aws:::s3: to arn:aws:s3:::, this change fixes the error * New datasets not being deployed New dataset creation skipped if previous datasets already exists changed exit 0 to continue in order to deploy the next dataset if the current one already exists. * Update deploy.sh Co-authored-by: Arenas Garcia --- .../pipeline-examples/alternative-sdlf-dataset/deploy.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdlf-utils/pipeline-examples/alternative-sdlf-dataset/deploy.sh b/sdlf-utils/pipeline-examples/alternative-sdlf-dataset/deploy.sh index 85bdf8be..4feb37a6 100755 --- a/sdlf-utils/pipeline-examples/alternative-sdlf-dataset/deploy.sh +++ b/sdlf-utils/pipeline-examples/alternative-sdlf-dataset/deploy.sh @@ -137,7 +137,7 @@ do # Don't fail for no-op update if [[ $update_output == *"ValidationError"* && $update_output == *"No updates"* ]] ; then echo -e "\nFinished create/update - no updates to be performed"; - exit 0; + continue else exit $status fi @@ -165,4 +165,4 @@ do --condition-expression "attribute_exists(#N)" echo "$TEAM_NAME-$DATASET_NAME DynamoDB Dataset entry updated" fi -done \ No newline at end of file +done