Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add property to update lambda version when lambda layer is updated #3661

Merged
merged 14 commits into from
Nov 6, 2024

Conversation

aaythapa
Copy link
Contributor

@aaythapa aaythapa commented Oct 9, 2024

Issue #, if available

#3648

Description of changes

Added an opt-in property to AWS::Serverless::LayerVersion. When enabled alongside AutoPublishAliasAllProperties in the connected Lambda function there will be a new lambda version created for every change made to the LayerVersion resource

Description of how you validated changes

Created and ran integ test. Integ test changes Description and ContentUri property to ensure a new Lambda version is created.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaythapa aaythapa marked this pull request as ready for review October 10, 2024 18:29
@aaythapa aaythapa requested a review from a team as a code owner October 10, 2024 18:29
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, really nice integration test. One nit: can you add a unit tests for function with 2 layers, one with the new property true and one undefined. Confirm that changing the undefined property layer wouldn't cause new hash.

Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaythapa aaythapa enabled auto-merge (squash) November 6, 2024 08:16
@aaythapa aaythapa merged commit fa7549f into aws:develop Nov 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants