Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 by default #117

Closed
Guillem96 opened this issue May 27, 2022 · 9 comments
Closed

Python 3.8 by default #117

Guillem96 opened this issue May 27, 2022 · 9 comments

Comments

@Guillem96
Copy link

Is there any specific reason why the default Python version is 3.7 while Python 3.8, or even 3.9 is completely mature>

Being honest it's a bit cumbersome to constantly downgrade my SageMaker training dependencies to meet the Python 3.7 requirements.

Thank you,

@lorenzwalthert
Copy link

lorenzwalthert commented May 27, 2022

Per #113 (which was later merged into master) the source code is at 3.9, but the images from the default ECRs are not as mentioned there.

@mabunday
Copy link
Contributor

mabunday commented Jun 2, 2022

This change will make 3.8 default for 1.0: #118

It should be reflected in the default ECRs by 6/10.

@Guillem96
Copy link
Author

Thanks!

@lorenzwalthert
Copy link

I can’t see any new image in the ECRs for 5 weeks though… so not sure this should be closed.

@mabunday
Copy link
Contributor

Which ECR are you looking at?

@lorenzwalthert
Copy link

lorenzwalthert commented Jun 20, 2022

AWS_DEFAULT_PROFILE=AnalysisSandbox aws ecr get-login-password --region eu-central-1 | docker login --username AWS --password-stdin 492215442770.dkr.ecr.eu-central-1.amazonaws.com
REPO="492215442770.dkr.ecr.eu-central-1.amazonaws.com/sagemaker-scikit-learn"
docker image ls $REPO

gives

REPOSITORY                                                               TAG                        IMAGE ID       CREATED         SIZE
492215442770.dkr.ecr.eu-central-1.amazonaws.com/sagemaker-scikit-learn   0.23-1-cpu-py3             de591cbba55f   6 weeks ago     4.15GB
492215442770.dkr.ecr.eu-central-1.amazonaws.com/sagemaker-scikit-learn   1.0-1-cpu-py3              bcfce5c2f01a   6 weeks ago     4.33GB
492215442770.dkr.ecr.eu-central-1.amazonaws.com/sagemaker-scikit-learn   0.23-1-cpu-py3-1.0.205.0   42981ecdd106   18 months ago   3.21GB

@mabunday
Copy link
Contributor

I may be wrong, but I believe that command only lists local images that have already been pulled from that repository.

The Python 3.8 image was pushed on Jun 7th. Try pulling 492215442770.dkr.ecr.eu-central-1.amazonaws.com/sagemaker-scikit-learn:1.0-1-cpu-py3

docker image ls "492215442770.dkr.ecr.eu-central-1.amazonaws.com/sagemaker-scikit-learn"                                                       
REPOSITORY                                                               TAG             IMAGE ID       CREATED       SIZE
492215442770.dkr.ecr.eu-central-1.amazonaws.com/sagemaker-scikit-learn   1.0-1-cpu-py3   ff85d0034e62   2 weeks ago   3.63GB

@lorenzwalthert
Copy link

Right.. Thanks for the hint. I can confirm it has Python 3.8 now. Great. Our code base has Python 3.9 though... Are you planning to further bump Python after fixing #106?

@mabunday
Copy link
Contributor

We don't currently have it on the roadmap, but yes once #106 is resolved I don't think there should be many blockers preventing us from bumping to 3.9 so I'd like to do that ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants