-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Block Bitmap Calculation #504
Conversation
94de5af
to
5efd6cc
Compare
Thank you for updating the PR, sorry for the delay. Please take a look at the PR checks and correct the issues, you seem to be missing a closing parentheses on line 2268 in ota.c. Thank you! |
Sorry about that, I couldn't run the tests locally. |
/bot run formatting |
No worries! Thank you for applying the fix. |
Hi, is this going to be merged? |
Hi, @BogdanTheGeek, my apologies for the delay. Reviewing the remaining checks now. |
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Fixes #503
Description
Multiply buffer size by element size (byte). Maybe this should use
sizeof(*pFileBitmap)
.I am not able to run the unit tests as I only have access to a mac and the unit tests depend on
mqueue.h
.Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.