Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Block Bitmap Calculation #504

Merged
merged 13 commits into from
Jan 29, 2024
Merged

Fix Block Bitmap Calculation #504

merged 13 commits into from
Jan 29, 2024

Conversation

BogdanTheGeek
Copy link
Contributor

@BogdanTheGeek BogdanTheGeek commented Dec 14, 2023

Fixes #503

Description

Multiply buffer size by element size (byte). Maybe this should use sizeof(*pFileBitmap).
I am not able to run the unit tests as I only have access to a mac and the unit tests depend on mqueue.h.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • My code is formatted using Uncrustify.
  • I have read and applied the rules stated in CONTRIBUTING.md.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bradleysmith23 bradleysmith23 self-requested a review December 14, 2023 02:09
bradleysmith23
bradleysmith23 previously approved these changes Dec 14, 2023
@bradleysmith23
Copy link

Thank you for updating the PR, sorry for the delay. Please take a look at the PR checks and correct the issues, you seem to be missing a closing parentheses on line 2268 in ota.c. Thank you!

@BogdanTheGeek
Copy link
Contributor Author

Sorry about that, I couldn't run the tests locally.

@bradleysmith23
Copy link

/bot run formatting

@bradleysmith23
Copy link

bradleysmith23 commented Dec 23, 2023

Sorry about that, I couldn't run the tests locally.

No worries! Thank you for applying the fix.
For the remaining checks, I can take a look at them and push a fix if that works with you. I will be away for a few days but will be able to do this later next week.

@BogdanTheGeek
Copy link
Contributor Author

Hi, is this going to be merged?

@bradleysmith23
Copy link

Hi, @BogdanTheGeek, my apologies for the delay. Reviewing the remaining checks now.

@aggarg aggarg merged commit 2557f84 into aws:main Jan 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OTA Block size check wrong
5 participants