Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

SQS error code not match #654

Closed
chuzui opened this issue Nov 29, 2023 · 2 comments
Closed

SQS error code not match #654

chuzui opened this issue Nov 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists service-api This issue pertains to the AWS API sqs

Comments

@chuzui
Copy link

chuzui commented Nov 29, 2023

Describe the bug

After the aws/aws-sdk-go#5060, for example, the error code of deleting a non-existent queue is changed from AWS.SimpleQueueService.NonExistentQueue to NonExistentQueue. But the SQS api comes back with AWS.SimpleQueueService.NonExistentQueue in practise and make the error code check unworkable.

aws/aws-sdk-go-v2#2348
#105

Expected Behavior

The error code of deleting a non-existent queue can match sqs.ErrCodeQueueDoesNotExist

Current Behavior

Not match

Reproduction Steps

input := &sqs.DeleteQueueInput{
                 // non-existent queue
		QueueUrl: aws.String(url),
	}

if _, err := s.DeleteQueue(input); err != nil {
	if ae, ok := err.(awserr.Error); ok && ae.Code() == sqs.ErrCodeQueueDoesNotExist {
		return nil
	} else {
		return err
	}
}

Possible Solution

No response

Additional Information/Context

No response

SDK version used

1.47.13

Environment details (Version of Go (go version)? OS name and version, etc.)

go1.19.7 linux/amd64

@chuzui chuzui added bug Something isn't working needs-triage labels Nov 29, 2023
@RanVaknin
Copy link

Hi @chuzui,

Thanks for reaching out. This is a known issue, and needs to be fixed with the SQS team itself.

Related:
#105
#516

If you feel inclined, you can help us make this more visible by creating a support ticket in the AWS console.
Just make sure to mention to other open internal tickets P86218130 and V694663406 and mention my amazon alias @rvaknin so that support can reach out to me internally.

Thanks again,
Ran~

@RanVaknin RanVaknin self-assigned this Nov 29, 2023
@RanVaknin RanVaknin transferred this issue from aws/aws-sdk-go Nov 29, 2023
@RanVaknin RanVaknin added duplicate This issue or pull request already exists service-api This issue pertains to the AWS API sqs labels Nov 29, 2023
@chuzui chuzui closed this as completed Nov 30, 2023
Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working duplicate This issue or pull request already exists service-api This issue pertains to the AWS API sqs
Projects
None yet
Development

No branches or pull requests

2 participants