-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript compile error on latest library release (3.703.0) #6706
Comments
@trivikr I see new versions coming out, any change you're going to fix this type error? It's a common usage by S3 + request presigning, I bet this is going to become a big problem experience by many other devs soon. |
Could you please provide your minimal code reproduction? I don't see any issues on my end.
The code I have - import { GetObjectAclCommand, S3Client } from "@aws-sdk/client-s3";
import { getSignedUrl } from "@aws-sdk/s3-request-presigner";
const s3Client = new S3Client({ region: "us-east-1" });
const command = new GetObjectAclCommand({
Bucket: "new-bucket-maggie-ma",
Key: "0.txt",
//expiration: "4000"
});
const presigned = await getSignedUrl(s3Client, command, {
expiresIn: "3000",
// Set of all x-amz-* headers you wish to have signed
// unhoistableHeaders: new Set(["x-amz-checksum-sha256"]),
});
console.log(presigned) I think the error is because it accepts |
turns out it was dependency version mismatch, removing package lock and node modules, reinstalling and no problems. thanks |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Checkboxes for prior research
Describe the bug
Just updated to latest version:
This error happens now.
Just to be clear I aliased getSignedUrl, just to give some context:
import { S3 } from '@aws-sdk/client-s3';
import { getSignedUrl as getS3SignedUrl } from '@aws-sdk/s3-request-presigner';
see error below
Regression Issue
SDK version number
3.703.0
Which JavaScript Runtime is this issue in?
Node.js
Details of the browser/Node.js/ReactNative version
23.1.0
Reproduction Steps
try to build with typescript.
Observed Behavior
typescript error
Expected Behavior
no typescript error
Possible Solution
No response
Additional Information/Context
No response
The text was updated successfully, but these errors were encountered: