Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File/directory is opened but is not being closed. #4910

Closed
amankaur27 opened this issue Jul 14, 2023 · 5 comments
Closed

File/directory is opened but is not being closed. #4910

amankaur27 opened this issue Jul 14, 2023 · 5 comments
Assignees
Labels
bug This issue is a bug. p3 This is a minor priority issue queued This issues is on the AWS team's backlog

Comments

@amankaur27
Copy link

Describe the bug

I found some places where a file/directory is opened but it is not closed and it may lead to resource overhead issue. Consider following files:

aws-sdk-go/private/model/cli/api-info/api-info.go
aws-sdk-go/example/aws/credentials/plugin/plugin.go

Expected Behavior

The opened files/directories should be closed with defer.

Current Behavior

Right now, these are not closed.

Reproduction Steps

Possible Solution

No response

Additional Information/Context

No response

SDK version used

v1.38.64

Environment details (Version of Go (go version)? OS name and version, etc.)

go version 1.19.5, linux (Ubuntu 22.04.2 LTS)

@amankaur27 amankaur27 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 14, 2023
@RanVaknin
Copy link
Contributor

Hi @amankaur27 ,

Looks reasonable. Do you want to take a stab at raising a PR?

Thanks,
Ran~

@RanVaknin RanVaknin self-assigned this Jul 18, 2023
@RanVaknin RanVaknin added p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jul 18, 2023
@amankaur27
Copy link
Author

Hello @RanVaknin , Thanks for your reply. I am new to this platform. Could you explain what you mean by PR ?

@ziyaddin
Copy link

@amankaur27 Ran asks whether you would like to fix this bug and open a pull request (aka PR) including the fix so that they merge your fix to the main branch.

@RanVaknin RanVaknin added the queued This issues is on the AWS team's backlog label Aug 7, 2023
@manojmaurya17
Copy link

Hi @RanVaknin, Can you assigned this to me, I would like to work on this, if this issue is still open?

@lucix-aws lucix-aws closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p3 This is a minor priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

5 participants