Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 ReplicationRuleFilter and LifecycleRuleFilter change causes compilation errors #2833

Closed
3 tasks done
ewbankkit opened this issue Oct 14, 2024 · 2 comments
Closed
3 tasks done

Comments

@ewbankkit
Copy link

Acknowledgements

Describe the bug

The change to S3 ReplicationRuleFilter and LifecycleRuleFilter introduced in #2831 causes compilation errors:

Error: internal/service/s3/bucket_lifecycle_configuration.go:716:95: undefined: types.LifecycleRuleFilterMemberAnd
Error: internal/service/s3/bucket_lifecycle_configuration.go:747:74: undefined: types.LifecycleRuleFilterMemberTag

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

CHANGELOG entry notes a breaking change.

Current Behavior

Compilation error.

Reproduction Steps

import (
	"github.com/aws/aws-sdk-go-v2/service/s3/types"
)

	result := &types.LifecycleRuleFilterMemberAnd{
		Value: types.LifecycleRuleAndOperator{},
	}

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

% grep 'service/s3' go.mod 
	github.com/aws/aws-sdk-go-v2/service/s3 v1.65.3
	github.com/aws/aws-sdk-go-v2/service/s3control v1.49.2
	github.com/aws/aws-sdk-go-v2/service/s3outposts v1.28.2

Compiler and Version used

go 1.23.2

Operating System and version

macos

@ewbankkit ewbankkit added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2024
@github-actions github-actions bot added the potential-regression Marking this issue as a potential regression to be checked by team member label Oct 14, 2024
@lucix-aws
Copy link
Contributor

I've updated the release notes to explicitly note the break: f46593c

@lucix-aws lucix-aws removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. potential-regression Marking this issue as a potential regression to be checked by team member labels Oct 14, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants