From eae1ff653e4e53ccc79f0cbb0d3bbf9aee1330f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20Madrigal=20=F0=9F=90=A7?= <599908+Madrigal@users.noreply.github.com> Date: Tue, 10 Dec 2024 16:37:35 -0500 Subject: [PATCH] Remove port from tests since port is not actually used on DSQL token --- feature/dsql/auth/auth_token_generator_test.go | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/feature/dsql/auth/auth_token_generator_test.go b/feature/dsql/auth/auth_token_generator_test.go index 91db73890ac..32ea9d7b240 100644 --- a/feature/dsql/auth/auth_token_generator_test.go +++ b/feature/dsql/auth/auth_token_generator_test.go @@ -26,7 +26,7 @@ type tokenGenFunc func(ctx context.Context, endpoint, region string, creds aws.C func TestGenerateDbConnectAuthToken(t *testing.T) { cases := map[string]dbTokenTestCase{ "no region": { - endpoint: "https://oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws:3306", + endpoint: "https://oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws", expectedError: "no region", }, "no endpoint": { @@ -34,18 +34,12 @@ func TestGenerateDbConnectAuthToken(t *testing.T) { expectedError: "endpoint is required", }, "endpoint with scheme": { - endpoint: "https://oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws:3306", + endpoint: "https://oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws", region: "us-east-1", - expectedHost: "oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws:3306", + expectedHost: "oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws", expectedQueryParams: []string{"Action=DbConnect"}, }, "endpoint without scheme": { - endpoint: "oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws:3306", - region: "us-east-1", - expectedHost: "oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws:3306", - expectedQueryParams: []string{"Action=DbConnect"}, - }, - "endpoint without port": { endpoint: "oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws", region: "us-east-1", expectedHost: "oo0bar1baz2quux3quuux4.dsql.us-east-1.on.aws",