[develop] Add exp backoff in launch ec2 instances call on throttling #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
85adcdd to
9d35474
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #594 +/- ##
===========================================
+ Coverage 90.05% 90.17% +0.11%
===========================================
Files 16 16
Lines 2706 2708 +2
===========================================
+ Hits 2437 2442 +5
+ Misses 269 266 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
9d35474 to
5b8edfc
Compare
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
2 times, most recently
from
79916fc to
d73d4ba
Compare
Add error code and message on ClientError when launching instances, for RunInstances and CreateFleet API calls Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
d73d4ba to
a726ba2
Compare
Add exp backoff in launch ec2 instances call on throttling. This is specially useful during all-or-nothing scaling, during all-in optimization call, to avoid quiting the all-in call and enter the job loop. The longer retry time requires to increases the orphaned_instance_timeout by 1 min, from 120 to 180 secs Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
a726ba2 to
28606fd
Compare
EddyMM
approved these changes
Nov 8, 2023
lukeseawalker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is specially useful during all-or-nothing scaling, during all-in optimization call, to avoid quiting the all-in call and enter the job loop.
The longer retry time requires to increases the orphaned_instance_timeout by 3 min, from 120 to 300 secs
Tests
References
n/a
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.