-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop][wip-1] Job Level Scaling for Node Sharing case #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
September 5, 2023 13:12
7b79c6f
to
445bc72
Compare
Add temporary config to be able to enable node sharing jls, useful when developing the feature Signed-off-by: Luca Carrogu <[email protected]>
Split oversubscribed job list, to have ready to consume knowledge about * oversubscribed job list with single node allocation * oversubscribed job list with multiple node allocation * oversubscribed single node list * oversubscribed multi node list Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
September 5, 2023 14:35
b843ff5
to
825f050
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #558 +/- ##
===========================================
+ Coverage 89.44% 89.53% +0.09%
===========================================
Files 16 16
Lines 2633 2656 +23
===========================================
+ Hits 2355 2378 +23
Misses 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
3 times, most recently
from
September 6, 2023 14:08
a215e8b
to
16b8026
Compare
lukeseawalker
changed the title
[develop] Job Level Scaling for Node Sharing case
[develop][wip-1] Job Level Scaling for Node Sharing case
Sep 7, 2023
Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
September 7, 2023 14:16
8b58aea
to
afe527b
Compare
Change retry logic on DescribeInstances to be exponential backoff plus a random number in the interval 0 + 0.5. The random number is to add a jitter so to avoid wave requests. Retries have been increased from 4 to 5 Signed-off-by: Luca Carrogu <[email protected]>
Accumulate unused capacity over different instance launch calls, when it isn't possible to assign the full requested allocation to a job Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker
force-pushed
the
wip/nodeSharingJLS
branch
from
September 7, 2023 14:19
afe527b
to
7795ad3
Compare
NSsirena
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Series of changes needed for the work in progress feature "Job Level Scaling for Node Sharing".
Add temporary config to be able to enable node sharing jls, useful when developing the feature
Split oversubscribed job list, to have ready to consume knowledge about
* oversubscribed job list with single node allocation
* oversubscribed job list with multiple node allocation
* oversubscribed single node list
* oversubscribed multi node list
Change retry logic on DescribeInstances to be exponential backoff plus a random number in the interval 0 + 0.5.
The random number is to add a jitter so to avoid wave requests.
Retries have been increased from 4 to 5
Accumulate unused capacity over different instance launch calls, when it isn't possible to assign the full requested allocation to a job
Tests
References
Checklist
develop
add the branch name as prefix in the PR title (e.g.[release-3.6]
).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.