-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PQ] Add experimental support for PQ/T hybrid KEMs #1741
[PQ] Add experimental support for PQ/T hybrid KEMs #1741
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental-pq-hybrid #1741 +/- ##
==========================================================
+ Coverage 78.32% 78.34% +0.01%
==========================================================
Files 580 581 +1
Lines 96618 96833 +215
Branches 13853 13848 -5
==========================================================
+ Hits 75679 75862 +183
- Misses 20326 20359 +33
+ Partials 613 612 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to review the macrofication.
1d0fb39
into
aws:experimental-pq-hybrid
Description of changes:
Add an experimental implementation of PQ/T Hybrid KEMs in a new folder
crypto/pqt
. The header file iscrypto/pqt/pqt_kem.h
and the source file iscrypto/pqt/pqt_kem.c
.These KEMs are plugged into the existing KEM API via
crypto/kem/*
, andtool/speed.cc
is updated to enable benchmarking their performance.Call-outs:
Lines 399-490 in
crypto/pqt/pqt_kem.c
contain the core implementation. The rest is boilerplate.Testing:
These KEMs pass the
PerKEMTest
suite, minus the test vectors, which will be added in a subsequent commit.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.