Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read FIPS hash address using adrp instead of adr to increase reach #1731

Closed
wants to merge 2 commits into from

Conversation

dkostic
Copy link
Contributor

@dkostic dkostic commented Jul 31, 2024

Issues:

N/A

Description of changes:

This change extends #1332
to BORINGSSL_bcm_text_hash symbol.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

This change extends aws#1332
to `BORINGSSL_bcm_text_hash` symbol.
@dkostic dkostic requested a review from a team as a code owner July 31, 2024 22:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.29%. Comparing base (518df30) to head (9de8c3a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
- Coverage   78.29%   78.29%   -0.01%     
==========================================
  Files         580      580              
  Lines       96533    96533              
  Branches    13839    13838       -1     
==========================================
- Hits        75582    75579       -3     
- Misses      20337    20340       +3     
  Partials      614      614              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkostic dkostic closed this Aug 1, 2024
@dkostic dkostic deleted the fix-aarch64-fips-hash-delocator branch August 1, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants