Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkcs7 ctors #1710

Closed
wants to merge 45 commits into from
Closed

Pkcs7 ctors #1710

wants to merge 45 commits into from

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented Jul 16, 2024

Status

This PR is currently posted as a draft just to run coverity. This is not yet ready for review.

ToDo

  • move ASN1 definitions to their own file
  • go through each function and assert it's as close to OSSL as possible
  • doc comments
  • what to do about d2i and i2d functions? currently too customized.

Notes

  • in progress

Testing

  • in progress

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@WillChilds-Klein WillChilds-Klein force-pushed the pkcs7-ctors branch 3 times, most recently from 3a64ddb to fd02c67 Compare July 17, 2024 21:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 83.28076% with 53 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (8d5e8c1) to head (6016c77).
Report is 2 commits behind head on main.

Files Patch % Lines
crypto/pkcs7/pkcs7.c 81.30% 43 Missing ⚠️
crypto/pkcs7/pkcs7_x509.c 87.50% 8 Missing ⚠️
crypto/pkcs7/pkcs7_asn1.c 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
+ Coverage   78.43%   78.51%   +0.07%     
==========================================
  Files         580      581       +1     
  Lines       96756    97052     +296     
  Branches    13864    13912      +48     
==========================================
+ Hits        75892    76196     +304     
+ Misses      20247    20239       -8     
  Partials      617      617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein WillChilds-Klein force-pushed the pkcs7-ctors branch 3 times, most recently from 2ea95fa to 3ea9ec7 Compare July 24, 2024 15:48
@WillChilds-Klein WillChilds-Klein force-pushed the pkcs7-ctors branch 3 times, most recently from 4cda07a to 36371ba Compare July 26, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants