Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FlinkKinesisFirehoseProducer#createKinesisFirehoseClient protected to allow for instrumentation #15

Open
bobtiernay-okta opened this issue Feb 3, 2021 · 0 comments

Comments

@bobtiernay-okta
Copy link

bobtiernay-okta commented Feb 3, 2021

Currently FlinkKinesisFirehoseProducer#createKinesisFirehoseClient is package-private. This means it's not nice to create a refinement to instrument metrics, etc. against client operations. It would be great if the following were possible:

    /**
     * {@inheritDoc}
     * <p>See <a href="https://github.com/aws/aws-kinesisanalytics-flink-connectors/issues/15">aws-kinesisanalytics-flink-connector #15</a>
     * for description of why this is needed.
     */
    @Nonnull
    @Override
    protected AmazonKinesisFirehose createKinesisFirehoseClient() {
        return new MeteredAmazonKinesisFirehose(getRuntimeContext().getMetricGroup(), super.createKinesisFirehoseClient());
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant