Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full URLs for README.md #455

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Use full URLs for README.md #455

merged 1 commit into from
Jan 3, 2024

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Jan 2, 2024

Issue #, if available:

Description of changes:
The relative links are broken on API docs, as the API docs directly use the README.md. Update the README.md to use full URL so the links would not broken.

The downside of the change is that it always links to the docs on main branch even if you are working on a specific release/commit. However, I think for most use case, the readme would be accessed from the github page and api doc. It has less affect than the broken link on the API doc.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera merged commit 30d99a4 into main Jan 3, 2024
10 checks passed
@xiazhvera xiazhvera deleted the readme_link branch January 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants