Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish tarballs that include submodules #743

Open
2 tasks
ericriff opened this issue Aug 7, 2024 · 1 comment
Open
2 tasks

Publish tarballs that include submodules #743

ericriff opened this issue Aug 7, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@ericriff
Copy link

ericriff commented Aug 7, 2024

Describe the feature

The published assets for each release do not include the submodules. This means I can't wget the tarball and build this repo because the assets are incomplete.

Use Case

Download the tarball and build the repo. This is way faster than cloning and does't require git.

Also it would allow to use CMake's FetchContent feature to consume this repo as a dependency on another project.

Granted, FetchContent supports cloning the repo instead of downloading a tarball, but it is a way slower process.

Proposed Solution

IMO this is a feature that should be implemented by github but for whatever reason it is not there, so project maintainers have been supporting this on their own, E.g. :
AcademySoftwareFoundation/MaterialX#317
pytorch/pytorch#62708

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

all

Environment details (OS name and version, etc.)

Linux

@ericriff ericriff added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2024
@jmklix
Copy link
Member

jmklix commented Aug 13, 2024

Thanks for this suggestion. This is something that we might do at some point in the future, but we currently don't have any plans to publish tarballs anytime soon.

@jmklix jmklix added p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants