Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StreamManager] [KinesisConfig] upload acts as default batch_size is 500 #10

Open
bpawlik opened this issue Jul 29, 2020 · 2 comments
Open

Comments

@bpawlik
Copy link

bpawlik commented Jul 29, 2020

When uploading to Kinesis Data Streams with StreamManager, uploading happens in batches of 500 instead of immediately, even though batch_size value in ExportDefinition:KinesisConfig is not specified. According to documentation:

batch_size: The maximum size of a batch to send to Kinesis. Messages will be queued until the batch size is reached, after which they will then be uploaded. If unspecified the default will be 1.

Setting batch_size to 1, solves the issue, i.e. data is uploaded as it comes to the stream. Did I misread the documentation or is it a bug?

@MikeDombo
Copy link
Contributor

Thank you for bringing this to our attention you are correct that the default is not 1, but 500 (the maximum batch size). We will take this feedback and update the documentation to reflect this as soon as possible.

@bartek-aws
Copy link

Thanks for confirming the bug. Could you please keep this issue open until the fix to the documentation is merged with master?

@MikeDombo MikeDombo reopened this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants