Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ca-west-1 to list of known regions #1218

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

rjjaegeraws
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add ca-west-1 to the list of known regions to pass config validation phases.

Copy link
Contributor

@hickeydh-aws hickeydh-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hickeydh-aws hickeydh-aws merged commit 63ca3b3 into aws-samples:main Mar 6, 2024
5 of 6 checks passed
@rjjaegeraws rjjaegeraws deleted the yyc-enable-2 branch March 6, 2024 21:08
@jvescio-ssc
Copy link

The accelerator does not work when adding ca-west-1 to :

  • "global-options\supported-regions"
  • "replacements\addl_regions[a-c]"

Results:

  • The run fail because macie doesn't exist in ca-west-1 (we needed to exclude it in macie-excl-regions)
  • Needed to manually enable ca-west-1 in all accounts
  • Needed to manually enable sts Service tokens in ca-west-1 and global in all accounts
  • Keys and policies were not being pushed to the new regions in the accounts.

@rjjaegeraws
Copy link
Contributor Author

There are other considerations in addition to the ones listed (e.g. AWS Config rules). We are working on publishing a guide with sample configuration snippets to demonstrate how to get ca-west-1 configured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants