Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State enum inconsistencies between iOS, Android #12

Open
esilverberg opened this issue Nov 4, 2020 · 1 comment
Open

State enum inconsistencies between iOS, Android #12

esilverberg opened this issue Nov 4, 2020 · 1 comment

Comments

@esilverberg
Copy link

FYI, on Android, the State enum is defined:

    public static enum State {
        BUFFERING,
        PLAYING,
        READY,
        IDLE,
        ENDED;

        private State() {
        }
    }

But, on iOS, the IVSPlayerState is defined:

typedef NS_ENUM(NSInteger, IVSPlayerState) {
    /// Indicates that the status of the player is idle.
    IVSPlayerStateIdle,
    /// Indicates that the player is ready to play the selected source.
    IVSPlayerStateReady,
    /// Indicates that the player is buffering content.
    IVSPlayerStateBuffering,
    /// Indicates that the player is playing.
    IVSPlayerStatePlaying,
    /// Indicates that the player reached the end of the stream.
    IVSPlayerStateEnded,
} NS_SWIFT_NAME(IVSPlayer.State);

The ordinal values are different and it is breaking my efforts to create a react native wrapper across both platforms for AWS IVS.

Thanks!

@johnBartos
Copy link
Contributor

Hey @esilverberg, thanks for the good feedback! I'll bring this up with the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants