Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resource requirements by annotations #9

Closed
wants to merge 1 commit into from
Closed

Support resource requirements by annotations #9

wants to merge 1 commit into from

Conversation

ksauzz
Copy link

@ksauzz ksauzz commented May 11, 2022 •
edited
Loading

Fix #8

Add new annotations to define ResourceRequirements:

  • sidecar.aws.signing-proxy/cpu
  • sidecar.aws.signing-proxy/cpu-limit
  • sidecar.aws.signing-proxy/memory
  • sidecar.aws.signing-proxy/memory-limit

A example of manifest:

apiVersion: v1
kind: Pod
metadata:
  name: ubuntu
  annotations:
    sidecar.aws.signing-proxy/inject: "true"
    sidecar.aws.signing-proxy/host: "aps.us-west-2.amazonaws.com"
    sidecar.aws.signing-proxy/name: "aps"
    sidecar.aws.signing-proxy/region: "us-west-2"
    sidecar.aws.signing-proxy/cpu: "200m"
    sidecar.aws.signing-proxy/memory:  "200Mi"
    sidecar.aws.signing-proxy/cpu-limit: "400m"
    sidecar.aws.signing-proxy/memory-limit: "400Mi"
spec:
  containers:
  - name: ubuntu
    image: ubuntu:20.04
    # Just spin & wait forever
    command:
      - sleep
    args: [ "inifiny" ]

@ksauzz ksauzz force-pushed the feature/resource branch from e323457 to 378d3c4 Compare May 11, 2022 14:29
@ksauzz ksauzz marked this pull request as ready for review May 11, 2022 16:51
@ksauzz ksauzz force-pushed the feature/resource branch from 378d3c4 to 0ab34d1 Compare May 12, 2022 00:52
@ksauzz
Copy link
Author

ksauzz commented May 12, 2022

I forgot to push the latest change. I pushed it which was tested on local k3d.

@ksauzz ksauzz closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resources support
1 participant
@ksauzz