Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing if the propagator is set correctly #310

Open
NathanielRN opened this issue Jun 22, 2021 · 0 comments
Open

Testing if the propagator is set correctly #310

NathanielRN opened this issue Jun 22, 2021 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@NathanielRN
Copy link
Contributor

Description

In PR on AWS OTel Python aws-observability/aws-otel-python#14 I realized that I had not set the propagator correctly for one of my apps, yet I was still able to pass the validator

-c default-otel-trace-validation.yml --endpoint http://app:8080 --metric-namespace default -t ${{ github.run_id }}-${{ github.run_number }}

command without a problem because my traces were still appearing in X-Ray.

Is it possible to add an automatic test to check if the propagator is set by looking at the headers? The sample apps may need to be updated to do a more complicated setup too.

I remember I verified this manually by setting up CloudWatch Logs to monitor SQS messages sent from a Lambda which lead me to see that

"AWSTraceHeader": "Root=1-5fdd3a92-574ad3d7c4848e12227de280;Parent=018121e92134972f;Sampled=1",

was in fact included in the traces being sent to X-Ray.

@vasireddy99 vasireddy99 added enhancement New feature or request question Further information is requested labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants