Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth2clientauthextension #1492

Open
svrnm opened this issue Sep 15, 2022 · 23 comments
Open

Add oauth2clientauthextension #1492

svrnm opened this issue Sep 15, 2022 · 23 comments
Assignees
Labels

Comments

@svrnm
Copy link

svrnm commented Sep 15, 2022

Is your feature request related to a problem? Please describe.
The AppDynamics Cloud backend authenticates opentelemetry ingestion via oauth, for that we leverage the oauth2clientauthextension. For end-users who want to send telemetry from ADOT collector to our backend we have to ask them to put another collector in between.

Describe the solution you'd like

  • Add the oauth2clientauthextension to the ADOT collector
  • Add it to the reduced collector for lambda as well

Describe alternatives you've considered
We can ask customers to send data from adot collector to appd collector

Additional Context
I assume that we are not the only ones leveraging oauth2, so this is beneficial to other observability backends as well.

cc @liamoddell, @pavankrish123

@bryan-aguilar bryan-aguilar added the feature-request Feature request label Sep 16, 2022
@mhausenblas
Copy link
Member

@svrnm thanks for raising this request. It is indeed something we are hearing more often and consider this in a wider context.

@svrnm
Copy link
Author

svrnm commented Sep 19, 2022

thanks @mhausenblas!

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Nov 20, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2022
@mhausenblas mhausenblas removed the stale label Dec 26, 2022
@mhausenblas mhausenblas reopened this Dec 26, 2022
@gramtech
Copy link

We use AppDynamics and AWS extensively and are waiting to use ADOT however are blocked by the missing OAuth functionality.
Are there any updates on the timeline for when this will be available?

@noMoreCLI
Copy link

noMoreCLI commented Mar 6, 2023

Is there an update on a timeline when oAuth will be supported with ADOT?
For the full and reduced (read lambda) ADOT layers.

@mhausenblas
Copy link
Member

@noMoreCLI not yet, please sync up with @svrnm

@eriweb
Copy link

eriweb commented Apr 25, 2023

Any update on this?

@mhausenblas
Copy link
Member

@eriweb it's on our backlog, when we're getting closer to it I will provide some more guidance but for now, our thinking is to provide a comprehensive solution that may include also the Basic Authenticator. I would love to learn about your use case/requirements if you can share?

@eriweb
Copy link

eriweb commented Apr 25, 2023

@mhausenblas it is to send metrics/tracing to 3rd party solutions. We're currently trying to integrate with AppDynamics to get a combined view of AWS as well as on-prem solutions.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jun 25, 2023
@svrnm
Copy link
Author

svrnm commented Jun 26, 2023

Can this issue be marked to not stale at all? There is still demand for it :-)

@mhausenblas mhausenblas removed the stale label Jun 26, 2023
@vsakaram vsakaram assigned humivo and unassigned mhausenblas Aug 17, 2023
@mshoosht-cisco
Copy link

@mhausenblas Interestingly enough I found this thread because I as working on a metrics pipeline that consumes AppD Cloud, and AWS Prometheus. I have a sneaking suspicion the sigv4auth extension only works properly with the ADOT collector based on the Authorization header errors I have otherwise.

Copy link
Contributor

github-actions bot commented Nov 5, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Nov 5, 2023
@svrnm
Copy link
Author

svrnm commented Nov 6, 2023

This is still needed.

@github-actions github-actions bot removed the stale label Nov 12, 2023
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 14, 2024
@svrnm
Copy link
Author

svrnm commented Jan 15, 2024

This is still needed, please un-stale

@mhausenblas mhausenblas removed the stale label Jan 15, 2024
@gramtech
Copy link

Bump!
Cant be that hard to add, its already support in the contrib collector

https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/oauth2clientauthextension

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Apr 28, 2024
Copy link
Contributor

github-actions bot commented Jun 2, 2024

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
@mhausenblas mhausenblas removed the stale label Jun 3, 2024
@mhausenblas mhausenblas reopened this Jun 3, 2024
Copy link
Contributor

github-actions bot commented Aug 4, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

Copy link
Contributor

github-actions bot commented Oct 6, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Oct 6, 2024
@mhausenblas mhausenblas removed the stale label Oct 7, 2024
zaro0508 pushed a commit to Sage-Bionetworks-IT/schematic-infra-v2 that referenced this issue Nov 13, 2024
**Problem:**

1. An Opentelemetry collector needs to be deployed to ECS to support forwarding telemetry data for long-term storage and analysis.
2. A configuration file for the collector needs to be sourced from AWS secrets manager and injected into the Otel collector to configure the service.
3. Environment variables need to be updated in the schematic container to support configuring it to send telemetry data to the Otel collector.
4. A container level health check is needed as this service is not fronted by a load balancer.

**Solution:**

1. Deploying the otel collector contributor container to ECS. I had attempted to use the AWS otel collector, however, they do not support the Oauth2 extension that we will use to attached an Auth header on out-going requests: aws-observability/aws-otel-collector#1492
2. Storing the otel config file in AWS Secret manager and injecting it into the Otel collector by overriding the docker CMD command on the container.
3. Setting environment variables on the schematic container to configure it sending telemetry data to the otel collector.
4. Pointing to our sage specific docker image that contains a binary compiled from golang that does container level health checks.

**Testing:**

1. I verified that I was able to deploy both schematic and the otel collector to AWS ECS.
2. I verified that by setting the environment variables in schematic that it was able to produce, and forward it's data to the otel collector.
3. I verified that the otel collector was able to perform the oauth2 client credential exchange with Auth0 to obtain an access token.
4. I verified that both logs AND traces were forwarded to the kubernetes cluster/SigNoz and ingested into Clickhouse for long-term storage.
5. I verified that the telemetry data showed up in the SigNoz UI as expected.
Copy link
Contributor

github-actions bot commented Dec 8, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

8 participants