Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS.S3.delete_objects content md5 header #155

Open
LostKobrakai opened this issue Mar 6, 2023 · 5 comments
Open

AWS.S3.delete_objects content md5 header #155

LostKobrakai opened this issue Mar 6, 2023 · 5 comments

Comments

@LostKobrakai
Copy link
Contributor

AWS.S3.delete_objects requires a content md5 header, but there seems to be no way to provide it.

@onno-vos-dev
Copy link
Member

I believe the following two PRs would do if done for the Elixir code @LostKobrakai are you up for porting that over and opening a PR to the codegen library? Otherwise I can try and det done time aside during the week 👍

https://github.com/aws-beam/aws-codegen/pull/92/files
https://github.com/aws-beam/aws-codegen/pull/93/files

@LostKobrakai
Copy link
Contributor Author

@LostKobrakai
Copy link
Contributor Author

Hmm. I still get <Message>Missing required header for this request: Content-Md5.</Message> using this against a minio instance.

@LostKobrakai
Copy link
Contributor Author

LostKobrakai commented Mar 9, 2023

Finally, the Content-MD5 header is required for all Multi-Object Delete requests. Amazon S3 uses the header value to ensure that your request body has not been altered in transit.

That's from the docs https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteObjects.html.

Not sure how/why this wouldn't be part of the codegen definitions for headers.

@onno-vos-dev
Copy link
Member

@LostKobrakai Since I don't have any Elixir project running at the moment, I have a hard time testing this on Elixir unfortunately 😢

I assume this is still an issue right? I'd be happy to help debug this for you but I'm gonna need a hand here... 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants