From 621c6f6fa18b899da461f878e3d204301d0e3719 Mon Sep 17 00:00:00 2001
From: Erik Hanchett <ehhanche@amazon.com>
Date: Tue, 10 Dec 2024 15:50:16 -0800
Subject: [PATCH] Updated names based on code review

---
 mdx-components.tsx                                   |  4 ++--
 .../{Banner/Banner.tsx => AIBanner/AIBanner.tsx}     | 12 +++---------
 .../__tests__/AIBanner.test.tsx}                     |  8 ++++----
 src/components/AIBanner/index.tsx                    |  1 +
 src/components/Banner/index.tsx                      |  1 -
 src/components/Layout/Layout.tsx                     |  6 +++---
 6 files changed, 13 insertions(+), 19 deletions(-)
 rename src/components/{Banner/Banner.tsx => AIBanner/AIBanner.tsx} (87%)
 rename src/components/{Banner/__tests__/Banner.test.tsx => AIBanner/__tests__/AIBanner.test.tsx} (64%)
 create mode 100644 src/components/AIBanner/index.tsx
 delete mode 100644 src/components/Banner/index.tsx

diff --git a/mdx-components.tsx b/mdx-components.tsx
index c5e14e2528e..7ce3e403259 100644
--- a/mdx-components.tsx
+++ b/mdx-components.tsx
@@ -1,7 +1,7 @@
 import * as React from 'react';
 import type { MDXComponents } from 'mdx/types';
 import ExportedImage from 'next-image-export-optimizer';
-import { Banner } from './src/components/Banner';
+import { AIBanner } from './src/components/AIBanner';
 import InlineFilter from './src/components/InlineFilter';
 import { YoutubeEmbed } from './src/components/YoutubeEmbed';
 import { Accordion } from './src/components/Accordion';
@@ -65,7 +65,7 @@ export function useMDXComponents(components: MDXComponents): MDXComponents {
     InlineFilter,
     MigrationAlert,
     YoutubeEmbed,
-    Banner,
+    AIBanner,
     Overview,
     ExternalLink,
     ExternalLinkButton,
diff --git a/src/components/Banner/Banner.tsx b/src/components/AIBanner/AIBanner.tsx
similarity index 87%
rename from src/components/Banner/Banner.tsx
rename to src/components/AIBanner/AIBanner.tsx
index c1367cac40a..fd4db18e93a 100644
--- a/src/components/Banner/Banner.tsx
+++ b/src/components/AIBanner/AIBanner.tsx
@@ -2,13 +2,8 @@ import { Flex, Message, IconsProvider, Text } from '@aws-amplify/ui-react';
 import { IconStar, IconChevron } from '../Icons';
 import { Button } from '@aws-amplify/ui-react';
 
-interface BannerProps {
-  url?: string;
-}
-
-export const Banner: React.FC<BannerProps> = ({
-  url = '/react/ai/set-up-ai/'
-}) => {
+export const AIBanner: React.FC = () => {
+  const URL = '/react/ai/set-up-ai/';
   return (
     <IconsProvider
       icons={{
@@ -31,10 +26,9 @@ export const Banner: React.FC<BannerProps> = ({
 
           <Button
             as="a"
-            href={url}
+            href={URL}
             size="small"
             gap="small"
-            target="_blank"
             colorTheme="overlay"
             rel="noopener noreferrer"
             className="message-banner__button"
diff --git a/src/components/Banner/__tests__/Banner.test.tsx b/src/components/AIBanner/__tests__/AIBanner.test.tsx
similarity index 64%
rename from src/components/Banner/__tests__/Banner.test.tsx
rename to src/components/AIBanner/__tests__/AIBanner.test.tsx
index 335973d6411..60110d8ed8d 100644
--- a/src/components/Banner/__tests__/Banner.test.tsx
+++ b/src/components/AIBanner/__tests__/AIBanner.test.tsx
@@ -1,11 +1,11 @@
 import * as React from 'react';
 import { render, screen } from '@testing-library/react';
-import { Banner } from '../index';
+import { AIBanner } from '../index';
 
-describe('Banner', () => {
-  it('should render the Banner component', async () => {
+describe('AIBanner', () => {
+  it('should render the AIBanner component', async () => {
     const bannerText = 'Amplify AI kit is now generally available';
-    render(<Banner />);
+    render(<AIBanner />);
 
     const component = await screen.findByText(bannerText);
     expect(component).toBeInTheDocument();
diff --git a/src/components/AIBanner/index.tsx b/src/components/AIBanner/index.tsx
new file mode 100644
index 00000000000..8cf7601c7bb
--- /dev/null
+++ b/src/components/AIBanner/index.tsx
@@ -0,0 +1 @@
+export { AIBanner } from './AIBanner';
diff --git a/src/components/Banner/index.tsx b/src/components/Banner/index.tsx
deleted file mode 100644
index f4930c0719e..00000000000
--- a/src/components/Banner/index.tsx
+++ /dev/null
@@ -1 +0,0 @@
-export { Banner } from './Banner';
diff --git a/src/components/Layout/Layout.tsx b/src/components/Layout/Layout.tsx
index 018fc322e1d..b3419509203 100644
--- a/src/components/Layout/Layout.tsx
+++ b/src/components/Layout/Layout.tsx
@@ -29,7 +29,7 @@ import type { HeadingInterface } from '@/components/TableOfContents/TableOfConte
 import { Breadcrumbs } from '@/components/Breadcrumbs';
 import { debounce } from '@/utils/debounce';
 import '@docsearch/css';
-import { Banner } from '@/components/Banner';
+import { AIBanner } from '@/components/AIBanner';
 import { usePathWithoutHash } from '@/utils/usePathWithoutHash';
 import {
   NextPrevious,
@@ -72,7 +72,7 @@ export const Layout = ({
   const basePath = 'docs.amplify.aws';
   const metaUrl = url ? url : basePath + asPathWithNoHash;
   const pathname = router.pathname;
-  const shouldShowGen2Banner = asPathWithNoHash === '/';
+  const shouldShowAIBanner = asPathWithNoHash === '/';
   const isGen1 = asPathWithNoHash.split('/')[1] === 'gen1';
   const isContributor = asPathWithNoHash.split('/')[1] === 'contribute';
   const currentGlobalNavMenuItem = isContributor ? 'Contribute' : 'Docs';
@@ -274,7 +274,7 @@ export const Layout = ({
                         platform={currentPlatform}
                       />
                     ) : null}
-                    {shouldShowGen2Banner ? <Banner /> : null}
+                    {shouldShowAIBanner ? <AIBanner /> : null}
                     {useCustomTitle ? null : (
                       <Heading level={1}>{pageTitle}</Heading>
                     )}