-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Model deploy failure #916
Comments
Hey @DougalW, 👋 thank you for reaching out; By any chance do you observe a |
Hi ykethan, thanks for getting back so quickly. Deleting It is also giving this error a few times:
But when it occurs I haven't made that many changes to the data model. I also noticed that when I create a new data model, Amplify doesn't always create a matching form in the UI library. It seemed to stop creating new forms after it had created 32 forms. When I manually create a new form, not all the data models show up in the dialog when it asks if I want to base the form on a data model, so I created the form as blank then mapped it to the data model, using the drop down list which now shows all the available data models. After adding some more tables, I can no longer Save and Deploy my data models. |
Hey @DougalW, thank you for the information. I was able to reproduce the issue, marking this as bug. The Amplify studio and API team has been made aware into the behaviour are tracking this behaviour internally. |
Many thanks. FYI, the UI Library is now showing 45 forms - it's added 13 overnight following my last deployment. I was able to create the final few tables I needed but I cannot link them into other tables in the UI. |
hey @DougalW, could you provide some additional information on the unable to link behaviour you are experiencing on the UI? |
here's a video of the behaviour. I'm trying to create a form linked to the Opportunities table from my data model. I can't create the form because it doesn't show up in the menu for selecting tables, but once I create the blank form I can then link it as the Opportunities table shows up in the drop down. BrokenFormCreate.mov |
hey @DougalW, thank you for the video. I was able to reproduce the issue. When creating forms or linking a model with data model that contains a field with required relationship the model should not appear both the options, which is a bug. I have created a issue to track this behaviour on #924 as well. |
That's great news. Any idea when the bug fix for the Data Model issue (can't create more tables) will be available? I need to set aside some time to try pushing changes from my local schema - any guidance on how to do this would be appreciated. |
Hey @DougalW, to pull you existing Studio application to your local environment you will need to install Amplify CLI and then pull the app as provided here: https://docs.amplify.aws/console/adminui/extend-cli/ for the |
Thanks @ykethan I've pulled it down, and was exploring the model again in Amplify so made a few modifications just to see what happens, and it was allowing met to change and extend the data model. I did request an increase in my AppSync limit so perhaps this had some influence? |
Hey @DougalW, if you are able to push new data model using the CLI it should create DynamoDB. By any chance on a push do you see any limit errors? |
Hi @ykethan I renamed a table in my local schema.graphql file and pushed back to Amplify but it failed. Here's the log:
I notice the error is: Reason: Only one resolver is allowed per field. This is the same error when I try and change the table from the Amplify Studio UI. When I look in AppSync I can see that the resolver for that class (StrategyDevelopmentProcesses) now is not connected to any resolvers but in the Amplify Studio UI it shows correctly: and the table exists in DynamoDB: I also noticed three other tables that show up in AppSync without resolvers, but their tables do exist in DynamoDB:
To cross-check this, I opened the Amplify Studio UI and created a new table StrategyDevelopmentProcess, deleted the old StrategyDevelopmentProcesses table, and linked GovernanceOversightActivities to the new table, then deployed. It also failed with the same error. Next I returned to the UI and just created a new StrategyDevelopmentProcess table without changing anything else, and it again failed with the following UI log:
Next I created a totally different table in the Studio UI called "NewStrategyProcessTable" and deployed it with the following error log
This is very odd because the names of the new table is "NewStrategyProcessTable", not "StrategyDevelopmentProcesses". Then to check it wasn't mixing up table names, I created a new table with a totally different name and no fields, using the Studio UI, and deployed it successfully, then I renamed it to "StratDevProcess" and added the same fields as from the original "StrategyDevelopmentProcesses" table and deployed that successfully. Next I deleted the relationship from the "GovernanceOversightActivitiesDataSet" table to the "StrategyDevelopmentProcesses" table, deployed that change, then linked the "GovernanceOversightActivitiesDataSet" table to the "StratDevProcess" table and successfully deployed that. Lastly I successfully deleted the no-longer-needed "StrategyDevelopmentProcesses" table. This feels like an AppSync issue - it's clearly out of sync with the backend somehow and seems to confuse similar table names, or it can't handle changing tables with an existing relationship when there are a moderate number of tables. I'm keen to see your feedback on this issue - seems like a pretty big issue that needs urgent attention as it makes Amplify very hard to use for apps with 30+ tables, which is a pretty common situation. |
This issue is happening again. Just removed a relationship in one table, deployed the change successfully, then added a relationship in another table and deployed, which failed with the 'Too many open files' error. I deleted the deployment-state.json file, re-deployed the model, and this time it appeared to succeed but nothing was changed, and the Data Model UI in Studio showed the model as it was before I made the schema change. |
may also be related to issue #632 when using many:many relationships - seems like the internal 'book-keeping' that amplify performs doesn't account for relationship changes correctly. |
f |
Before opening, please confirm:
App Id
d2tkk8ivw3yqtf
Region
ap-southeast-2
Environment name
dev
Figma File Version (if applicable)
No response
Amplify CLI Version
10.6.2
If applicable, what version of Node.js are you using?
No response
What operating system are you using?
Mac
Browser type?
Safari 16.3
Describe the bug
Hi, I have a data model consisting of a set of 28 tables, 20 ENUM's and various relationships between the tables (40 are 1:1 and 15 are 1:many).
I am trying to add a new table and relationships via Amplify Studio, and the Data Model editor allows me to do this but when I click Save and Deploy, it says it has deployed the new data model but the new table is not there. When I inspect my Dynamo DB tables, the new table is also not present. When I look at Cloudformation there have been no new stacks run so it looks like the deploy was not submitted.
I have an ERD I can send privately, but would prefer not to share it publicly here.
Expected behavior
When I add a new table or relationship, or update and existing table or relationship, it will be saved and deployed in Amplify Studio Data Modelling.
Reproduction steps
Project Identifier
No response
Additional information
I have repeated these steps and see exactly the same behaviour - no Cloudformation changes and no new tables in DynamoDB, but Amplify Studio shows it has updated successfully.
The text was updated successfully, but these errors were encountered: