Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly created Figma primitive button with variants are not loaded into Amplify Studio when synced with Figma URL #856

Closed
kodimalarsakthivel opened this issue Mar 3, 2023 · 5 comments
Labels
bug An issue which has been identified as a bug ui-theme Issues related to UI builder theme

Comments

@kodimalarsakthivel
Copy link

Which Specific Feature is your question related to?

AWS Amplify Studio Sync UI Library with Figma components

Question

Newly created Figma primitive button with variants are not loaded into Amplify Studio when synced with Figma URL

Steps:

  1. New set of buttons are created in Figma Primitives with multiple variants.

new-buttons

  1. Created a new component X and used 2 variants of the newly created button

new-component that uses differnt variant of the buttons

  1. Sync Figma URL with AWS Amplify Studio in

Sync Figma

  1. The newly created component X is loaded in Amplify Studio.

Imported component in Amplify

Issue: The component X is having only the default version of the button on the Amplify, but we used different variants of the button.

At the same time, when I used the default Amplify Figma Kit (https://www.figma.com/file/hjRuNEMVN5zpJBwTlBqB5p/AWS-Amplify-UI-Kit-(Community)?node-id=588%3A617&t=yoriXQSR6unDoezL-0) , I have created a new component and used different variant buttons. When I sync this with Amplify studio its able to load the button with correct variant.

@kodimalarsakthivel kodimalarsakthivel added pending-triage An issue that is pending triage question An issue which is a question asked by a customer labels Mar 3, 2023
@ykethan ykethan added the ui-theme Issues related to UI builder theme label Mar 3, 2023
@scottyoung
Copy link

Hi @kodimalarsakthivel,

Thank you for reaching out with this issue. Can you try to run amplify pull for Newcomponent and load it in your browser? I'd like to see if the variants show up correctly in your React code. Thank you.

@scottyoung scottyoung added pending-response An issue is pending response from the issue requestor and removed pending-triage An issue that is pending triage labels Mar 3, 2023
@kodimalarsakthivel
Copy link
Author

kodimalarsakthivel commented Mar 6, 2023

Hello @scottyoung ,

Yes its working, the different variants are rendered when I use the component from Amplify on my react code base. But the text on the button is not rendered as it is from the figma file.

In the above screen I have Save and Cancel, but its always rendering Button, Button! this issue is still there!

@github-actions github-actions bot removed the pending-response An issue is pending response from the issue requestor label Mar 6, 2023
@ykethan ykethan added the bug An issue which has been identified as a bug label Mar 6, 2023
@scottyoung
Copy link

Hi @kodimalarsakthivel,

Please make sure your variant property names match those listed in the Amplify Primitive section of the Figma UI Kit. For example, your variant property names can be variant, size, type, hasIcon. We currently don't support text override from Figma so we recommend creating a variant of type with variants like Save and Cancel that have the different button texts you are looking to render.

@ykethan ykethan removed the question An issue which is a question asked by a customer label Aug 29, 2023
@ykethan
Copy link
Member

ykethan commented Jun 4, 2024

Closing for now, we have made some improvements on it. Do reach out if you are still experiencing this issue.

@ykethan ykethan closed this as completed Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue which has been identified as a bug ui-theme Issues related to UI builder theme
Projects
None yet
Development

No branches or pull requests

3 participants