Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New form generated from data model failing to export cancel button #793

Closed
4 tasks done
KingsleyStephens opened this issue Jan 13, 2023 · 5 comments
Closed
4 tasks done
Labels
bug An issue which has been identified as a bug pending-release Code has been merged but pending release studio-ui An issue that needs to be tracked by Studio Console team

Comments

@KingsleyStephens
Copy link

Before opening, please confirm:

App Id

dntco4q28bj1y

Region

southeast-2

Environment name

dev

Figma File Version (if applicable)

No response

Amplify CLI Version

No response

If applicable, what version of Node.js are you using?

No response

What operating system are you using?

Windows 10

Browser type?

Google Chrome

Describe the bug

When creating a new form based on a data model and exporting it, the cancel button is failing to be generated in the code.

Expected behavior

The code for the cancel button should be generated.

Reproduction steps

  1. Create a simple data model
  2. Create a new UI form
  3. Configure the form to update the data model
  4. Notice that the generated form has Reset, Cancel, and Submit buttons and that all buttons are set to be visible
  5. Pull the backend into development environment
  6. Inspect the generated code for the form and notice that it is missing the cancel button

Project Identifier

No response

Additional information

No response

@KingsleyStephens KingsleyStephens added the pending-triage An issue that is pending triage label Jan 13, 2023
@cwoolum
Copy link
Contributor

cwoolum commented Jan 13, 2023

Hi @KingsleyStephens , thank you for reporting this to us! What version of the CLI are you using?

@cwoolum cwoolum added bug An issue which has been identified as a bug pending-response An issue is pending response from the issue requestor and removed pending-triage An issue that is pending triage labels Jan 13, 2023
@KingsleyStephens
Copy link
Author

I am using CLI version 10.6.1 with Node.js version 16.15.1

@github-actions github-actions bot removed the pending-response An issue is pending response from the issue requestor label Jan 13, 2023
@ykethan ykethan added the studio-ui An issue that needs to be tracked by Studio Console team label Jan 17, 2023
@hein-j
Copy link

hein-j commented Jan 19, 2023

Hi @KingsleyStephens,
Thank you for raising. Here is the situation:

  • We started to exclude the Cancel button by default in the data-backed forms.
  • There was a drift between Studio and CLI 10.6.1, so you probably were seeing a Cancel button in the "View as end user" preview of the form in Studio, but not when you pulled down the form in CLI. This drift was fixed last Thursday.
  • However, there is still a drift in the edit view of the form in Studio (it shows the cancel button but the form actually does not have a cancel button). We will work on fixing this.
  • If you want the cancel button, what you can do right now is the following:
  1. go to Studio and click on the form in question
  2. click on the Cancel button in edit view
  3. toggle the "Cancel button visible" on and off.
  4. Check that in "View as end user", the cancel button is visible now.
    Screen Shot 2023-01-19 at 09 00 55

I will close this issue with this workaround. Please reopen should you have any other questions/ if I'm missing anything.
Edit: I will leave this issue open to track the bug fix mentioned above. Please let us know if we're missing anything here.

@hein-j hein-j closed this as completed Jan 19, 2023
@hein-j hein-j reopened this Jan 19, 2023
@hein-j hein-j added the pending-release Code has been merged but pending release label Jan 23, 2023
@ykethan
Copy link
Member

ykethan commented Jun 4, 2024

Closing this as its fixed

@ykethan ykethan closed this as completed Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue which has been identified as a bug pending-release Code has been merged but pending release studio-ui An issue that needs to be tracked by Studio Console team
Projects
None yet
Development

No branches or pull requests

4 participants