-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppSync realtime endpoint URL is not correct for AWS China regions #2945
Comments
Hi @wulianer, thanks for the report. We'll check with the AppSync team about this and get back to you. |
The fix for this issue has been merged and will be included in our next release. |
Thank you for the quick response for the fix! @mattcreaser |
This fix has been released in Amplify 2.24.1. Please let us know if you have any issues! |
This issue is now closed. Comments on closed issues are hard for our team to see. |
Before opening, please confirm:
Language and Async Model
Java
Amplify Categories
GraphQL API
Gradle script dependencies
// Put output below this line
Environment information
Please include any relevant guides or documentation you're referencing
No response
Describe the bug
Working on Android projects with AWS China service region. The AppSync Query/Mutation methods work well but no subscription method works. Looking into the network traffic detail, I found that the Amplify SDK mistakenly processes the AWS China's realtime endpoint URL to a not existing endpoint URL thus causes the subscription failure . Below is the block of source code that needs update:
All AWS China region AppSync endpoint URLs end with
amazonaws.com.cn
thus they will not met the stanadardEndpointRegex and will be added/realtime
. This is not correct for these URLs.Besides above code snippet, there are multiple places that have this similar logic to check if an endpoint is a custom domain URL. All of them need update to support China AWS region
Reproduction steps (if applicable)
No response
Code Snippet
// Put your code below this line.
Log output
amplifyconfiguration.json
No response
GraphQL Schema
Additional information and screenshots
No response
The text was updated successfully, but these errors were encountered: